On Thu, Feb 04, 2021 at 11:37:08AM +0100, Claudio Jeker wrote: > Instead of passing around variables all the way down to entity_write_req() > and repo_lookup() use global variables. Especially for the repository > handling this will become more complex with the introduction of RRDP. > Also shuffle code around a bit so that all entity queue functions are > together. > > OK?
ok tb One very important comment below > @@ -114,10 +114,9 @@ filepathcmp(struct filepath *a, struct f > > RB_HEAD(filepath_tree, filepath); > RB_PROTOTYPE(filepath_tree, filepath, entry, filepathcmp); > -struct filepath_tree fpt = RB_INITIALIZER(&fpt); > > -static void entityq_flush(struct msgbuf *, struct entityq *, > - const struct repo *); > +static struct filepath_tree fpt = RB_INITIALIZER(&fpt); > +static struct msgbuf procq, rsyncq; The above line has "tab space tab" between type and variable name.
