On Thu, Feb 25, 2021 at 09:34:45PM +0100, Mark Kettenis wrote: > > Date: Thu, 25 Feb 2021 20:10:00 +0100 > > From: Marcus Glocker <mar...@nazgul.ch> > > > > We had this discussion recently when fbtab(5) for xenodm(1) was fixed > > 6 weeks ago, but we didn't come to an agreement yet. tb@ asked me the > > same question yesterday whether we can add video(1) to fbtab to avoid > > manual chown of /dev/video0, which I think a lot of people do today. > > Therefore here another try to bring this up. > > > > This diff adds /dev/video0 to fbtab on all archs where video is > > available. It's added for the existing console login entry, in case > > people start X through startx/xinit, and on a new entry when X is > > started through xenodm. > > > > On all other archs than amd64, i386, arm64, and macppc I'm not sure > > whether I have picked the right xenodm tty. Therefore I would be glad > > if people can verify that, and let me know. If you run X on that arch > > an easy way to identify this is: > > > > grep consolePath /var/log/xenodm.log > > xenodm info (pid 13760): consolePath: ttyC4 > > > > This additional entry could be also used later on to move the xenodm > > GiveConsole/TakeConsole chown entries over, I guess. > > > > Any thoughts? > > The xenodm tty should really be ttyC4 on all our architectures. I > would suggest that anywhere where you're not sure (or have something > different) we shouldn't add /dev/video0. People won't be using a > webcam on those platforms anyway. And if they do they can file a bug > report and we fix things.
Agree. I've tested on amd64, i386 is obvious, tb@ tested on macppc. Index: etc/etc.amd64/fbtab =================================================================== RCS file: /cvs/src/etc/etc.amd64/fbtab,v retrieving revision 1.8 diff -u -p -u -p -r1.8 fbtab --- etc/etc.amd64/fbtab 12 Feb 2021 10:26:33 -0000 1.8 +++ etc/etc.amd64/fbtab 25 Feb 2021 20:42:24 -0000 @@ -1 +1,2 @@ -/dev/ttyC0 0600 /dev/console:/dev/wskbd:/dev/wskbd0:/dev/wsmouse:/dev/wsmouse0:/dev/ttyCcfg:/dev/ttyC4:/dev/drm0:/dev/drmR128:/dev/dri/card0:/dev/dri/renderD128 +/dev/ttyC0 0600 /dev/console:/dev/wskbd:/dev/wskbd0:/dev/wsmouse:/dev/wsmouse0:/dev/ttyCcfg:/dev/ttyC4:/dev/drm0:/dev/drmR128:/dev/dri/card0:/dev/dri/renderD128:/dev/video0 +/dev/ttyC4 0600 /dev/video0 Index: etc/etc.i386/fbtab =================================================================== RCS file: /cvs/src/etc/etc.i386/fbtab,v retrieving revision 1.15 diff -u -p -u -p -r1.15 fbtab --- etc/etc.i386/fbtab 12 Feb 2021 10:26:34 -0000 1.15 +++ etc/etc.i386/fbtab 25 Feb 2021 20:42:24 -0000 @@ -1 +1,2 @@ -/dev/ttyC0 0600 /dev/console:/dev/wskbd:/dev/wskbd0:/dev/wsmouse:/dev/wsmouse0:/dev/ttyCcfg:/dev/ttyC4:/dev/drm0:/dev/drmR128:/dev/dri/card0:/dev/dri/renderD128 +/dev/ttyC0 0600 /dev/console:/dev/wskbd:/dev/wskbd0:/dev/wsmouse:/dev/wsmouse0:/dev/ttyCcfg:/dev/ttyC4:/dev/drm0:/dev/drmR128:/dev/dri/card0:/dev/dri/renderD128:/dev/video0 +/dev/ttyC4 0600 /dev/video0 Index: etc/etc.macppc/fbtab =================================================================== RCS file: /cvs/src/etc/etc.macppc/fbtab,v retrieving revision 1.13 diff -u -p -u -p -r1.13 fbtab --- etc/etc.macppc/fbtab 12 Feb 2021 10:26:34 -0000 1.13 +++ etc/etc.macppc/fbtab 25 Feb 2021 20:42:24 -0000 @@ -1,3 +1,4 @@ /dev/ttya 0600 /dev/console /dev/tty00 0600 /dev/console -/dev/ttyC0 0600 /dev/console:/dev/wskbd:/dev/wskbd0:/dev/wsmouse:/dev/wsmouse0:/dev/ttyCcfg:/dev/ttyC4:/dev/drm0:/dev/drmR128:/dev/dri/card0:/dev/dri/renderD128 +/dev/ttyC0 0600 /dev/console:/dev/wskbd:/dev/wskbd0:/dev/wsmouse:/dev/wsmouse0:/dev/ttyCcfg:/dev/ttyC4:/dev/drm0:/dev/drmR128:/dev/dri/card0:/dev/dri/renderD128:/dev/video0 +/dev/ttyC4 0600 /dev/video0
