> Date: Fri, 5 Mar 2021 12:05:38 +0100
> From: Jan Klemkow <j.klem...@wemelug.de>
> Content-Type: text/plain; charset=us-ascii
> Content-Disposition: inline
> 
> Hi,
> 
> this diff adds the missing PCI classes Accelerator and Instrumentation.
> Thus, we can replace a few unknown in its output:
> 
> -       0x0008: Class: 13 (unknown), Subclass: 00 (unknown),
> +       0x0008: Class: 13 Instrumentation, Subclass: 00 (null),

Is this "(null)" the result of printing a null pointer?  That would be
not so good.

> Both Classes have vendor specific APIs.  So, there are no predefined
> subclasses.
> 
> OK?
> 
> bye,
> Jan
> 
> Index: pcidump.c
> ===================================================================
> RCS file: /cvs/src/usr.sbin/pcidump/pcidump.c,v
> retrieving revision 1.61
> diff -u -p -r1.61 pcidump.c
> --- pcidump.c 17 Jan 2021 11:54:15 -0000      1.61
> +++ pcidump.c 5 Mar 2021 10:57:27 -0000
> @@ -1296,6 +1296,9 @@ static const struct pci_subclass pci_sub
>       { PCI_SUBCLASS_DASP_MISC,               "Miscellaneous" },
>  };
>  
> +static const struct pci_subclass pci_subclass_accelerator[] = {0};
> +static const struct pci_subclass pci_subclass_instrumentation[] = {0};
> +
>  #define CLASS(_c, _n, _s) { \
>       .class = _c, \
>       .name = _n, \
> @@ -1338,6 +1341,10 @@ static const struct pci_class pci_classe
>           pci_subclass_crypto),
>       CLASS(PCI_CLASS_DASP,           "DASP",
>           pci_subclass_dasp),
> +     CLASS(PCI_CLASS_ACCELERATOR,    "Accelerator",
> +         pci_subclass_accelerator),
> +     CLASS(PCI_CLASS_INSTRUMENTATION, "Instrumentation",
> +         pci_subclass_instrumentation),
>  };
>  
>  static const struct pci_class *
> 
> 

Reply via email to