Alexander Bluhm <alexander.bl...@gmx.net> wrote: > I hope to have addressed all issues. > > On Sun, Mar 07, 2021 at 11:50:24AM +0000, Visa Hankala wrote: > > This copyin() can also result in copying the buffer from userspace twice. > > This might not be a problem with log data though. > > Is double copyin a problem? I think error != EFAULT should catch > all cases.
It is not ideal, because the sendsyslog() copyin() has error handling but the logstash_insert() version ignores errors. It would be better if the buffer was only copied in once. In reality this codepath is only going to be used during boot, when no user-written programs are running..
