> Date: Fri, 12 Mar 2021 11:30:04 +0100 > From: Jan Klemkow <[email protected]> > > Hi, > > This diff add a missing PCI ID of an Intel NVMe disk. The disk works > after my last fix [1]. > > OK?
That seems to be a poorly chosen name. I believe this is what ark.intel.com calls a "Intel SSD DC P4510 Series" part. Is that correct? In that case I would suggest "DC P4510 NVMe" as the name. > [1]: https://marc.info/?l=openbsd-tech&m=161418460303831 > > Index: pcidevs > =================================================================== > RCS file: /cvs/src/sys/dev/pci/pcidevs,v > retrieving revision 1.1959 > diff -u -p -r1.1959 pcidevs > --- pcidevs 27 Feb 2021 03:00:54 -0000 1.1959 > +++ pcidevs 12 Mar 2021 10:16:44 -0000 > @@ -3465,6 +3465,7 @@ product INTEL CORE4G_M_ULT_GT3 0x0a26 HD > product INTEL CORE4G_S_ULT_GT3 0x0a2a HD Graphics > product INTEL CORE4G_R_ULT_GT3_1 0x0a2b HD Graphics > product INTEL CORE4G_R_ULT_GT3_2 0x0a2e Iris Graphics 5100 > +product INTEL NVME_1 0x0a54 NVMe Datacenter SSD > product INTEL GMA3600_0 0x0be0 GMA 3600 > product INTEL D2000_IGD 0x0be1 Atom D2000/N2000 Video > product INTEL GMA3600_2 0x0be2 GMA 3600 > Index: pcidevs.h > =================================================================== > RCS file: /cvs/src/sys/dev/pci/pcidevs.h,v > retrieving revision 1.1953 > diff -u -p -r1.1953 pcidevs.h > --- pcidevs.h 27 Feb 2021 03:01:25 -0000 1.1953 > +++ pcidevs.h 12 Mar 2021 10:16:46 -0000 > @@ -3470,6 +3470,7 @@ > #define PCI_PRODUCT_INTEL_CORE4G_S_ULT_GT3 0x0a2a /* HD > Graphics */ > #define PCI_PRODUCT_INTEL_CORE4G_R_ULT_GT3_1 0x0a2b /* HD > Graphics */ > #define PCI_PRODUCT_INTEL_CORE4G_R_ULT_GT3_2 0x0a2e /* Iris > Graphics 5100 */ > +#define PCI_PRODUCT_INTEL_NVME_1 0x0a54 /* NVMe > Datacenter SSD */ > #define PCI_PRODUCT_INTEL_GMA3600_0 0x0be0 /* GMA 3600 */ > #define PCI_PRODUCT_INTEL_D2000_IGD 0x0be1 /* Atom > D2000/N2000 Video */ > #define PCI_PRODUCT_INTEL_GMA3600_2 0x0be2 /* GMA 3600 */ > Index: pcidevs_data.h > =================================================================== > RCS file: /cvs/src/sys/dev/pci/pcidevs_data.h,v > retrieving revision 1.1948 > diff -u -p -r1.1948 pcidevs_data.h > --- pcidevs_data.h 27 Feb 2021 03:01:25 -0000 1.1948 > +++ pcidevs_data.h 12 Mar 2021 10:16:46 -0000 > @@ -11304,6 +11304,10 @@ static const struct pci_known_product pc > "Iris Graphics 5100", > }, > { > + PCI_VENDOR_INTEL, PCI_PRODUCT_INTEL_NVME_1, > + "NVMe Datacenter SSD", > + }, > + { > PCI_VENDOR_INTEL, PCI_PRODUCT_INTEL_GMA3600_0, > "GMA 3600", > }, > >
