On Sun, Mar 21, 2021 at 02:38:42PM +0100, Florian Obser wrote:

> 
> Don't warn that we can't form a temporary address when a router
> deprecates a prefix by sending a pltime of 0, this is normal.
> Continue warning when the pltime is smaller than 5 as this is almost
> certainly a configuration error.
> 
> OK?

yes,

        -Otto

> 
> diff --git engine.c engine.c
> index 7b49b330328..94a4a232d6a 100644
> --- engine.c
> +++ engine.c
> @@ -1932,14 +1932,15 @@ update_iface_ra_prefix(struct slaacd_iface *iface, 
> struct radv *ra,
>  
>       /* privacy addresses do not depend on eui64 */
>       if (!found_privacy && iface->autoconfprivacy) {
> -             if (prefix->pltime < PRIV_REGEN_ADVANCE) {
> +             if (prefix->pltime >= PRIV_REGEN_ADVANCE) {
> +                     /* new privacy proposal */
> +                     gen_address_proposal(iface, ra, prefix, 1);
> +             } else if (prefix->pltime > 0) {
>                       log_warnx("%s: pltime from %s is too small: %d < %d; "
>                           "not generating privacy address", __func__,
>                           sin6_to_str(&ra->from), prefix->pltime,
>                           PRIV_REGEN_ADVANCE);
> -             } else
> -                     /* new privacy proposal */
> -                     gen_address_proposal(iface, ra, prefix, 1);
> +             }
>       }
>  }
>  
> 
> 
> -- 
> I'm not entirely sure you are real.
> 

Reply via email to