Hello,

> 
> You missed the initialization of ipsendraw_mq. Otherwise, ICMP with and
> without IP options work for me with the diff.
> 
> I don't know how this is usually handled here and it is probably a bit
> nit-picky, but I introduced a new function to remove the duplicate code
> in ip_send_dispatch and ip_sendraw_dispatch. I am not a 100% happy
> about the function name, but it was the best I could come up with.
> 
> Also, I added a comment in icmp_send(), because it is probably not
> immediately obvious why ip_send_raw() is used.
> New diff below.
> 

    thanks for fixing up diff. it looks much better now. I still would like to
    receive at least one OK from OpenBSD network gang to commit the change to
    tree. 

thanks and
regards
sashan

Reply via email to