Stefan Sperling writes:
> On Wed, May 05, 2021 at 04:30:50PM +0200, Stefan Sperling wrote: >> This ensures that if WPA offloading is in use iwx(4) only sets link >> state UP once firmware has confirmed that crypto keys have been >> installed successfully. >> >> iwm(4) could use a similar patch, but I've not written that yet. >> >> ok? > > My previous diff had bugs, fixed here: > > Because iwx offloads both the pairwise key and the group key, depending > on when the setkey task gets scheduled this task might have to either > install one key per run or two keys in a single run. > The previous code could lead to a problem where the group key didn't > get installed, breaking broadcast/multcast traffic. > This was reported by Hrvoje who has confirmed that this version of > the patch fixes the issue. > > And obviously we should mark the link UP only once both keys have been > installed successfully. > > (The previous approach would have worked on iwm because iwm only offloads > the pairwise key.) > So far so good on my system. No regressions getting connected and using tcpbench(1) to my router that runs 6.9-stable. S3 working fine. iwx0 at pci3 dev 0 function 0 "Intel Wi-Fi 6 AX200" rev 0x1a, msix iwx0: hw rev 0x340, fw ver 48.1335886879.0, address 08:d2:3e:ee:17:8b I don't know enough of this codebase to comfortably OK, but I can say it seems to be working fine. -dv
