On Mon, May 24, 2021 at 04:10:00PM BST, Theo de Raadt wrote:
> But does it matter?

Did this[0] matter?

Well, in the grand scheme of things, not many things do, really.

Or is it just about the length of the vendor ID?

If the latter, then yes - a bit unfortunate that it's on the longer
side... I didn't come up with the name.

Maybe remove all without any product IDs? Your call.

[0] 
https://cvsweb.openbsd.org/src/sys/dev/usb/usbdevs.diff?r1=1.698&r2=1.699&sortby=date&f=h

R.

> It adds sizeof pointer + 28 bytes to every OpenBSD kernel.
> 
> I have seriously considered deleting usbdevs device-naming support,
> because the cost keeps growing without bound.
> 
> Raf Czlonka <[email protected]> wrote:
> 
> > On Mon, May 24, 2021 at 04:00:20PM BST, Theo de Raadt wrote:
> > > Without proof it is required, no.
> > 
> > Sure - hope this will suffice.
> > 
> > Before:
> > 
> >     uhidev1 at uhub3 port 2 configuration 1 interface 0 "vendor 0x1ea7 2.4G 
> > Mouse" rev 1.10/2.00 addr 4
> > 
> > After:
> > 
> >     uhidev1 at uhub3 port 2 configuration 1 interface 0 "SHARKOON 
> > Technologies GmbH 2.4G Mouse" rev 1.10/2.00 addr 4
> > 
> > Cheers,
> > 
> > Raf
> > 
> > > Raf Czlonka <[email protected]> wrote:
> > > 
> > > > Hello,
> > > > 
> > > > Pretty self-explanatory - add "SHARKOON Technologies GmbH" vendor ID.
> > > > 
> > > > Regards,
> > > > 
> > > > Raf
> > > > 
> > > > Index: sys/dev/usb/usbdevs
> > > > ===================================================================
> > > > RCS file: /cvs/src/sys/dev/usb/usbdevs,v
> > > > retrieving revision 1.740
> > > > diff -u -p -r1.740 usbdevs
> > > > --- sys/dev/usb/usbdevs 18 May 2021 14:23:03 -0000      1.740
> > > > +++ sys/dev/usb/usbdevs 24 May 2021 14:37:14 -0000
> > > > @@ -618,6 +618,7 @@ vendor SELUXIT              0x1d6f  Seluxit
> > > >  vendor METAGEEK                0x1dd5  MetaGeek
> > > >  vendor SIMCOM          0x1e0e  SIMCom Wireless Solutions Co., Ltd.
> > > >  vendor FESTO           0x1e29  Festo
> > > > +vendor SHARKOON                0x1ea7  SHARKOON Technologies GmbH
> > > >  vendor MODACOM         0x1eb8  Modacom
> > > >  vendor AIRTIES         0x1eda  AirTies
> > > >  vendor LAKESHORE       0x1fb9  Lake Shore
> > > > 

Reply via email to