Got it! I am trying to upgrade iwx firmwares version to -59 to support future gen3 devices and I found this section, so I post the info, that's my fault, thank you for correct me!
Regards, zxystd ------------------ Original ------------------ From: "Stefan Sperling" <[email protected]>; Date: Mon, Jun 14, 2021 05:23 PM To: "zxystd"<[email protected]>; Cc: "tech"<[email protected]>; Subject: Re: iwm(4): use new firmware images with fragattack fixes On Mon, Jun 14, 2021 at 03:58:39PM +0800, zxystd wrote: > Hi Stefan, > > Did we missed the 'umac_prph_offset' constant value in > iwm_clear_persistence_bit function? From linux code, it is read_umac_prph, > not read_prph, so the function should be looks like this: > > int > +iwm_clear_persistence_bit(struct iwm_softc *sc) > +{ > + uint32_t hpm, wprot; > + > + hpm = iwm_read_prph_unlocked(sc, umac_prph_offset + IWM_HPM_DEBUG); This patch is about iwm(4) only, so we don't need umac_prph_offset here. As far as I can tell, umac_prph_offset is 0 on every device, except on AX201 devices where it is 0x300000. See cfg/22000.c in iwlwifi: #define IWL_DEVICE_AX210 \ IWL_DEVICE_22000_COMMON, \ .trans.umac_prph_offset = 0x300000, \ I don't see this constant being set anywhere else. iwm(4) will never support AX201 devices. We only need to take care of this offset in iwx(4) which could eventually add support for AX201.
