Re: ksh: require expression in while loop

[Alexander Hall]

On July 5, 2021 8:31:49 AM GMT+02:00, "Reuben ua Bríġ" <u5644...@anu.edu.au> 
wrote:
>> Date: Sun,  4 Jul 2021 16:25:39 -0600
>> From: Todd C. Miller <mill...@openbsd.org>
>
>> let's just require a non-empty expression but still allow an empty
>> loop body.
>
>if i might suggest a slight variation, how about only requiring that
>at least one of the lists is non-empty, in the case of while, and
>leaving for, until, etc. as they are?
>
>this way nothing is broken.

I don't really see what you win either. Apart from inconsistency. ;-)

/Alexander

>
>your diff might then look something like:
>
>               t->left = c_list(true);
>               t->right = dogroup();
>+              if (t->left == NULL && t->right == NULL)
>+                      syntaxerr(NULL);