On Mon, Jul 12, 2021 at 01:47:25PM +0200, Tobias Heider wrote: > On Sun, Jul 11, 2021 at 05:33:18AM +0300, Vitaliy Makkoveev wrote: > > This member is never set or used. Also I kept 'SENT_IP6' definition for > > prevent the potential break of third party software. Is it ok to > > redefine it to '0x0002'? At least openswan wants this [1]. > > > > 1. > > https://github.com/xelerance/Openswan/blob/master/include/openswan/ipsec_encap.h#L20 > > I wouldn't worry about third party software. Those defines are within > #ifdef _KERNEL so everyone using those is doing it wrong anyway. >
'sockaddr_encap' structure defined outside _KERNEL boundaries but some related definitions like 'sen_*' and 'SENT_*' are defined within. This makes 'sockaddr_encap' definition inconsistent. We don't use this structure outside kernel, so it looks like it should not be visible to userland too. > ok with SENT_IP6 changed to 0x0002. > Commited, thanks.
