On Thu, Jul 22, 2021 at 10:31:53PM +0200, Martijn van Duren wrote:
> This type-O snuck in when merging traphandler into snmpe.
> Not a big deal since it's there just for ASN1/SMI strictness, but it
> breaks when introducing SNMPv3 support.
>
> OK?
ok jmatthew@
>
> martijn@
>
> Index: snmpe.c
> ===================================================================
> RCS file: /cvs/src/usr.sbin/snmpd/snmpe.c,v
> retrieving revision 1.72
> diff -u -p -r1.72 snmpe.c
> --- snmpe.c 20 Jun 2021 19:55:48 -0000 1.72
> +++ snmpe.c 22 Jul 2021 20:31:31 -0000
> @@ -381,7 +381,7 @@ badversion:
> case SNMP_C_TRAPV2:
> if (msg->sm_pdutype == SNMP_C_TRAPV2 &&
> !(msg->sm_version == SNMP_V2 ||
> - msg->sm_version != SNMP_V3)) {
> + msg->sm_version == SNMP_V3)) {
> msg->sm_errstr = "trapv2 request on !SNMPv2C or "
> "!SNMPv3 message";
> goto parsefail;
>
>
