On Thu, Aug 12, 2021 at 06:44:51AM +0200, Theo Buehler wrote: > There doesn't seem to be a good reason for omitting the newlines here. > If those are ever hit, it will look odd. Am I missing something?
See the i386 p3_get_bus_clock() which is where this came from. i386 prints the msr value and a newline. Wether that part is added to amd64 or removed from i386 it would be best to keep them in sync as much as possible. > > Index: est.c > =================================================================== > RCS file: /cvs/src/sys/arch/amd64/amd64/est.c,v > retrieving revision 1.40 > diff -u -p -r1.40 est.c > --- est.c 11 Aug 2021 18:15:50 -0000 1.40 > +++ est.c 12 Aug 2021 04:40:14 -0000 > @@ -185,7 +185,7 @@ p3_get_bus_clock(struct cpu_info *ci) > bus_clock = BUS333; > break; > default: > - printf("%s: unknown Core FSB_FREQ value %d", > + printf("%s: unknown Core FSB_FREQ value %d\n", > ci->ci_dev->dv_xname, bus); > break; > } > @@ -209,7 +209,7 @@ p3_get_bus_clock(struct cpu_info *ci) > bus_clock = BUS200; > break; > default: > - printf("%s: unknown Atom FSB_FREQ value %d", > + printf("%s: unknown Atom FSB_FREQ value %d\n", > ci->ci_dev->dv_xname, bus); > break; > } > @@ -291,14 +291,14 @@ est_acpi_pss_changed(struct acpicpu_pss > if ((acpilist = malloc(sizeof(struct fqlist), M_DEVBUF, M_NOWAIT)) > == NULL) { > printf("est_acpi_pss_changed: cannot allocate memory for new " > - "est state"); > + "est state\n"); > return; > } > > if ((acpilist->table = mallocarray(npss, sizeof(struct est_op), > M_DEVBUF, M_NOWAIT)) == NULL) { > printf("est_acpi_pss_changed: cannot allocate memory for new " > - "operating points"); > + "operating points\n"); > free(acpilist, M_DEVBUF, sizeof(struct fqlist)); > return; > } > >