Re: [patch] traceroute timeouts

[Stuart Henderson]

Shell aliases are good for that.

I think I'd be happy with 3 seconds by default. 2 feels a bit short on 
overloaded links, GPRS, and some round-the-world packet trips

--
 Sent from a phone, apologies for poor formatting.

On 20 August 2021 16:30:24 Tom Smyth <tom.sm...@wirelessconnect.eu> wrote:

Hello all,,
would it make sense
to have the value as a sysctl  option or an environment variable     ?
so that it can be tailored for users  /admins needs,



On Fri 20 Aug 2021, 12:22 Mark Kettenis, <mark.kette...@xs4all.nl> wrote:

> From: Florian Obser <flor...@openbsd.org>
> Date: Fri, 20 Aug 2021 10:46:21 +0200
>
> Makes sense to me, OK florian

Doesn't make sense to me.  The RTT for an ICMP packet can be a
significant part of a second (think Europe-Australia the wrong way
around cause that is where all the bandwidth is, or when satellites
are involved).  I think this means that a single dropped packet could
result in a failure to resolve one of the hops on such a path.

I don't necessarily object to giving folks the ammunition to shoot
themselves into the foot by dropping the minimum value to 1 second.
But the default should be larger I think.

> On 2021-08-19 23:47 -07, <jo...@armadilloaerospace.com> wrote:
> > The default traceroute timeout of 5 seconds is excruciatingly long
> > when there are elements of the route that don't respond, and it
> > wasn't allowed to be set lower than 2 seconds.
> >
> > This changes the minimum to 1 second, matching FreeBSD, and also
> > makes that the default, which should be reasonable for the vast
> > majority of users today.
> >
> > The two awk files in this directory are two decades old, and
> > not installed anywhere they can be executed as part of a traceroute
> > pipeline; can they be removed? If the functionality is useful,
> > implementing mean/median reporting as a new option in C would be
> > straightforward.
> >
> > Index: usr.sbin/traceroute/traceroute.8
> > ===================================================================
> > RCS file: /cvs/src/usr.sbin/traceroute/traceroute.8,v
> > retrieving revision 1.69
> > diff -u -p -u -r1.69 traceroute.8
> > --- usr.sbin/traceroute/traceroute.8        11 Feb 2020 18:41:39
-0000      1.69
> > +++ usr.sbin/traceroute/traceroute.8        20 Aug 2021 06:33:30 -0000
> > @@ -201,7 +201,7 @@ and
> >  are listed.
> >  .It Fl w Ar waittime
> >  Set the time, in seconds, to wait for a response to a probe.
> > -The default is 5.
> > +The default is 1.
> >  .It Fl x
> >  Print the ICMP extended headers if available.
> >  This option is not available for IPv6.
> > Index: usr.sbin/traceroute/traceroute.c
> > ===================================================================
> > RCS file: /cvs/src/usr.sbin/traceroute/traceroute.c,v
> > retrieving revision 1.164
> > diff -u -p -u -r1.164 traceroute.c
> > --- usr.sbin/traceroute/traceroute.c        12 Jul 2021 15:09:21
-0000      1.164
> > +++ usr.sbin/traceroute/traceroute.c        20 Aug 2021 06:33:30 -0000
> > @@ -351,7 +351,7 @@ main(int argc, char *argv[])
> >     rcvsock4 = rcvsock6 = sndsock4 = sndsock6 = -1;
> >     v4sock_errno = v6sock_errno = 0;
> >
> > -   conf->waittime = 5 * 1000;
> > +   conf->waittime = 1000;
> >
> >     if ((rcvsock6 = socket(AF_INET6, SOCK_RAW, IPPROTO_ICMPV6)) == -1)
> >             v6sock_errno = errno;
> > @@ -554,9 +554,9 @@ main(int argc, char *argv[])
> >                             err(1, "setsockopt SO_RTABLE");
> >                     break;
> >             case 'w':
> > -                   conf->waittime = strtonum(optarg, 2, INT_MAX,
&errstr);
> > +                   conf->waittime = strtonum(optarg, 1, INT_MAX,
&errstr);
> >                     if (errstr)
> > -                           errx(1, "wait must be >1 sec.");
> > +                           errx(1, "wait must be >=1 sec.");
> >                     conf->waittime *= 1000;
> >                     break;
> >             case 'x':
> >
> >
>
> --
> I'm not entirely sure you are real.
>
>