Re: Diff: Function Length Reduction

[Tom Cosgrove]

For example, making it look something like this would be better

static void
inc_buf(SCR *sp, VICMD *vp)
{
        CHAR_T v = vp->buffer;

        if (v < '1' || v > '8') return;

        VIP(sp)->sdot.buffer = vp->buffer = ++v;
}


Thanks

Tom

On 10/09/2021 22:24, Stuart Henderson wrote:

On 2021/09/10 16:39, VARIK VALEFOR wrote:

Is any particular aspect of the replacement code bad?

The use of 'magic number' ASCII values obfuscates what the code is
doing.