Using FIDO/U2F (Yubikey) from browser is not working with the latest snapshot.
After some testing and bisecting, I found out that the bug was introduced with the following commit: commit adb06565acb8061f0e1ddb764fb29f86eadeb2f6 from: anton <[email protected]> date: Fri Sep 10 05:47:38 2021 UTC Instead of letting uhidev drivers get the report sizes, do it once in uhidev and pass the same sizes as part of the attach arguments. Makes the uhidev drivers a bit less repetitive. It might look tempting to let uhidev assign the sizes after a driver has attached, removing the need to repeat this logic in each driver. This does however not work since the input size must be known while calling uhidev_open() in order to open the interrupt pipe; and uhidev_open() is called from several attach routines. Note that this change only works and applies to when attaching to a single report ID. https://github.com/openbsd/src/commit/adb06565acb8061f0e1ddb764fb29f86eadeb2f6 I have verified that it works again after reverting that single commit. -- Renato
