On Mon, Oct 25, 2021 at 01:46:51PM +0200, Sebastien Marie wrote:
> I have a working llvm13 here for building zig 0.9.0-dev.
> 
> /usr/src/usr.bin/openssl/s_client.c:897:16: error: variable 'pbuf_off' set 
> but not used [-Werror,-Wunused-but-set-variable]
>         int pbuf_len, pbuf_off;
>                       ^
> /usr/src/usr.bin/openssl/s_client.c:897:6: error: variable 'pbuf_len' set but 
> not used [-Werror,-Wunused-but-set-variable]
>         int pbuf_len, pbuf_off;
>             ^

Thanks. Your tree is slightly out of date. I removed pbuf_off already
but missed that I could remove pbuf_len for the same reason.

> > Your call regarding the 2nd & 3rd. If that structure really can be used
> > in multiple files then "static" is probably not appropriate.  Or maybe
> > the structure should just be moved to x509/x509_lib.c.

I missed this on review of job's addition of the RFC 3779 support. These
files should not include this.

I already gave an ok for all three diffs.

Reply via email to