Claudio Jeker <[email protected]> wrote: > This diff replaces the errx() call in the poll fd check with warnings plus > an exit of the main event loop. It also prints an error in case not all > files have been processed. > > An example after kill -9 of the rsync process is: > rpki-client: https://rrdp.lacnic.net/rrdp/notification.xml: loaded from > network > rpki-client: poll[1]: hangup > rpki-client: rsync terminated signal 9
I am not thrilled with giving people error messages about a system call (poll). In this specific case, the actual issue is on the next like (it is a rsync failure, which you caused I suspect) Is that 2nd message not enough? Could you set hangup = 1, but skip the warnx, so that the code just reacts correctly? Are there other circumstances (different types of fd), which do not make it to a wait (rrdp?). Can those report a nice termination message?
