Hello,
On Fri, Nov 26, 2021 at 04:32:59PM +1100, Jonathan Gray wrote:
> Stop building the kernel with -Wno-uninitialized on clang archs.
> This hides real problems like the recently fixed uninitialised memory
> use in pf and igc.
yes, please. I'd like to have the warning enabled.
I'm just able to build amd64,i386 only, not other archs
so can't OK those archs.
amd64 builds with warning enabled.
i386 seems to rquire two touches below. those diffs are just my wild
guess to keep build running. I'm far from saying it's correct
fix.
thank you for proposing this change.
regards
sashan
--------8<---------------8<---------------8<------------------8<--------
diff --git a/sys/dev/ic/tea5757.c b/sys/dev/ic/tea5757.c
index 3a4bafa3dc6..d416a80e382 100644
--- a/sys/dev/ic/tea5757.c
+++ b/sys/dev/ic/tea5757.c
@@ -159,7 +159,7 @@ tea5757_encode_lock(u_int8_t lock)
ret = TEA5757_S010;
else if (lock > 14 && lock < 51)
ret = TEA5757_S030;
- else if (lock > 50)
+ else
ret = TEA5757_S150;
return ret;
diff --git a/sys/dev/pci/fmsradio.c b/sys/dev/pci/fmsradio.c
index 5ab13f2ea5b..07310664603 100644
--- a/sys/dev/pci/fmsradio.c
+++ b/sys/dev/pci/fmsradio.c
@@ -537,7 +537,8 @@ fmsradio_get_info(void *v, struct radio_info *ri)
ri->info |= buf & PCR_INFO_STEREO ? 0 : RADIO_INFO_STEREO;
break;
default:
- break;
+ ri->rfreq = 0;
+ return (-1);
}
ri->freq = radio->freq = tea5757_decode_freq(buf,
