Re: Silence vmd rtc_update_rega non-32KHz timebase spam

[Brian Conway]

Ping with complete diff. Thanks.

Brian Conway

diff --git usr.sbin/vmd/mc146818.c usr.sbin/vmd/mc146818.c
index e3599c685..001c1a055 100644
--- usr.sbin/vmd/mc146818.c
+++ usr.sbin/vmd/mc146818.c
@@ -34,7 +34,6 @@
 #include "vmd.h"
 #include "vmm.h"

-#define MC_DIVIDER_MASK 0xe0
 #define MC_RATE_MASK 0xf

 #define NVRAM_CENTURY 0x32
@@ -236,10 +235,6 @@ rtc_reschedule_per(void)
 static void
 rtc_update_rega(uint32_t data)
 {
-    if ((data & MC_DIVIDER_MASK) != MC_BASE_32_KHz)
-        log_warnx("%s: set non-32KHz timebase not supported",
-            __func__);
-
     rtc.regs[MC_REGA] = data;
     if ((rtc.regs[MC_REGA] ^ data) & 0x0f)
         vm_pipe_send(&dev_pipe, MC146818_RESCHEDULE_PER);


On Thu, Nov 18, 2021 at 8:02 AM Brian Conway <bcon...@rcesoftware.com> wrote:
>
> Per https://marc.info/?l=openbsd-misc&m=159113575425726 , mlarkin@
> suggested someone can remove it. It's still pretty spammy at the
> current time for me.
>
> Brian Conway
> Software Engineer, Owner
> RCE Software, LLC
>
> diff --git usr.sbin/vmd/mc146818.c usr.sbin/vmd/mc146818.c
> index e3599c68504..17cf21221e5 100644
> --- usr.sbin/vmd/mc146818.c
> +++ usr.sbin/vmd/mc146818.c
> @@ -236,10 +236,6 @@ rtc_reschedule_per(void)
>  static void
>  rtc_update_rega(uint32_t data)
>  {
> -    if ((data & MC_DIVIDER_MASK) != MC_BASE_32_KHz)
> -        log_warnx("%s: set non-32KHz timebase not supported",
> -            __func__);
> -
>      rtc.regs[MC_REGA] = data;
>      if ((rtc.regs[MC_REGA] ^ data) & 0x0f)
>          vm_pipe_send(&dev_pipe, MC146818_RESCHEDULE_PER);