On Sat, Jan 15, 2022 at 11:54:00PM +1100, Jonathan Gray wrote: > On Sat, Jan 15, 2022 at 12:21:59PM +0000, Visa Hankala wrote: > > If the ending address in sfcc_cache_wbinv_range(), pa + len, is not > > cache-line-aligned, the function spins because len wraps around. > > The following patch fixes this. > > > > There still is a subtle detail. If len is zero but pa is non-aligned, > > the function is not a no-op. However, shouldn't upper layers handle > > things so that zero length does not reach this deep? > > > > OK? > > This driver was added to workaround the lack of coherency on > beaglev and is unused on the unmatched (sifive,fu740-c000-ccache). > > The polarfire device tree has sifive,fu540-c000-ccache this > driver matches on but does it actually need this driver?
The Technical Reference Manual indicates that the data caches and main interconnects are coherent. However, I am not sure about that yet.