On Tue, Jan 18, 2022 at 07:59:20AM +0300, Andrew Krasavin wrote:
> Hello!
> 
> Is there a reason not to enable dt(4) on macppc by default? I have
> built a kernel with dt enabled for test purposes and it seems to work
> correctly - commands like 'btrace /usr/share/btrace/kprofile.bt'
> work and I get stacks.
> 
> Maybe I'm missing something and there are known problems? But if
> not - maybe dt(4) should be enabled by default on macppc?
> 
> The diff I used is obvious, but anyway:
> 
> --- sys/arch/macppc/conf/GENERIC.orig
> +++ sys/arch/macppc/conf/GENERIC
> @@ -406,4 +406,6 @@ owtemp* at onewire?         # Temperature
>  owctr* at onewire?                     # Counter device
>  pseudo-device  hotplug 1       # devices hot plugging
> +pseudo-device  dt
> +
>  pseudo-device  wsmux   2       # mouse & keyboard multiplexor
> 
> In any case - thanks.

This gets us useful flamegraphs on macppc.
Feedback? Objections? OK?


Index: sys/arch/macppc/conf/GENERIC
===================================================================
RCS file: /cvs/src/sys/arch/macppc/conf/GENERIC,v
retrieving revision 1.275
diff -u -p -r1.275 GENERIC
--- sys/arch/macppc/conf/GENERIC        21 Oct 2021 18:36:42 -0000      1.275
+++ sys/arch/macppc/conf/GENERIC        21 Jan 2022 11:36:54 -0000
@@ -406,4 +406,5 @@ owtemp* at onewire?         # Temperature
 owctr* at onewire?                     # Counter device
 
 pseudo-device  hotplug 1       # devices hot plugging
+pseudo-device  dt
 pseudo-device  wsmux   2       # mouse & keyboard multiplexor

Reply via email to