> Date: Fri, 21 Jan 2022 16:18:28 +0100 (CET)
> From: Mark Kettenis <[email protected]>
>
> > Date: Fri, 21 Jan 2022 16:05:49 +0100
> > From: Stefan Sperling <[email protected]>
> >
> > On Sun, Jan 16, 2022 at 07:38:11PM +0100, Mark Kettenis wrote:
> > > > Date: Sun, 16 Jan 2022 19:28:06 +0100
> > > > From: Stefan Sperling <[email protected]>
> > > >
> > > > On Sun, Jan 16, 2022 at 03:50:55PM +0100, Mark Kettenis wrote:
> > > > > However, running this diff I had a problem after resuming my laptop
> > > > > twice. After resume the interface didn't work and I found the
> > > > > following in dmesg:
> > > > >
> > > > > iwm0: could not initialize hardware
> > > > >
> > > > > I tried to reset the interface by bringing it down and up again, which
> > > > > crashed the machine. It must have been in ddb since typing "bo re"
> > > > > made it reset. Unfortunately I don't have further information since I
> > > > > was in X.
> > > >
> > > > Did you try reproducing this problem without the patch in place?
> > > > It would be good to know whether this problem is being introduced by
> > > > this patch. I don't believe this is likely, my bet would be that this
> > > > is an existing problem. But it would be good to know for sure.
> > >
> > > Yes. I switched back to regular snapshots. Will keep you posted.
> > >
> >
> > Any news?
> >
> > I have unsuccessfully tried to reproduce this problem on a laptop
> > with a 9560 iwm device, via both S3 suspend and hibernate.
> > I do not have a 9260 device in a machine which can suspend, unfortunately.
> >
> > This was not a problem that occurred for you consistently, was it?
> > If so, even if you have not yet seen the failure without the patch,
> > I would like to commit this patch to unblock further progress. If the
> > error happens for more people afterwards we could investigate further.
> > Hopefully someone will be able to provide a trace from ddb.
>
> Didn't happen again after switching back to a snapshot kernel. It did
> happen somewhat frequently. But what may have triggered it is that I
> suspended while using my phone as a hotspot.
>
> I'm ok if you want to move ahead. I can recognize the issue and get a
> proper backtrace the next time this happens.
Happened again while still on a Jan 16 snapshot kernel. So it is not
related to that diff.
Here is the panic message and backtrace:
panic: kernel diagnostic assertion "sc->task_refs.refs == 0" failed: file
"/usr/src/sys/dev/pci/if_iwm.c", line 9981
Stopped at db_enter+0x10: popq %rbp
TID PID UID PRFLAGS PFLAGS CPU COMMAND
*120744 85293 0 0x3 0 0K ifconfig
db_enter() at db_enter+0x10
panic() at panic+0xbf
__assert() at __assert+0x25
iwm_init() at iwm_init+0x254
iwm_ioctl() at iwm_ioctl+0xf9
ifioctl() at ifioctl+0x92b
soo_ioctl() at soo_ioctl+0x161
sys_ioctl() at sys_ioctl+0x2c4
syscall() at syscall+0x374
Xsyscall() at Xsyscall+0x128
end of kernel
