Mark Kettenis <[email protected]> writes:

>>              for (bit = 0; bit <= (limit - base); bit++) {
>> -                    pin = gpiobase + bit;
>> -                    if (status & (1 << bit) && sc->sc_pin_ih[pin].ih_func)
>> -                            
>> sc->sc_pin_ih[pin].ih_func(sc->sc_pin_ih[pin].ih_arg);
>> -                    handled = 1;
>> +                    if (status & (1 << bit))
>> +                            handled |= pchgpio_intr_handle(sc, group, bit);
>>                                            ^
>> Isn't this --------------------------------^
>> returning 0 or 1? Why the bitwise operation when handled is being set to
>> 1 immediately prior? Am I missing something here?
>
> That line immediately prior is a line that gets removed ;).

Ha, I need to get my eyes checked again.

I can't speak for other non-sunrisepoint platforms, but it tests fine
for me and looks ok.

-dv

Reply via email to