without commenting on the substance of this change, it should definitely not be added to the copyright block
On Fri, 4 Mar 2022, patrick keshishian wrote: > Hello, > > I took a wrong turn, and got interested in where the SMBATT_CMD_* > defines were sourced. > > Adding a reference to Smart Battery Data Spec might save someone > else the time searching through ACPI spec, then SMBus spec, to > finally arriving at the answer. > > Is the following diff acceptable? > I believe this is the correct/definitive source. > > Thanks, > --patrick > > > Index: smbus.h > =================================================================== > RCS file: /cvs/obsd/src/sys/dev/acpi/smbus.h,v > retrieving revision 1.1 > diff -u -p -u -p -r1.1 smbus.h > --- smbus.h 22 Feb 2017 16:39:56 -0000 1.1 > +++ smbus.h 5 Mar 2022 07:37:06 -0000 > @@ -2,6 +2,9 @@ > * Copyright (c) 2005 Hans Petter Selasky > * All rights reserved. > * > + * Smart Battery Data Specification > + * http://sbs-forum.org/specs/sbdat110.pdf > + * > * Redistribution and use in source and binary forms, with or without > * modification, are permitted provided that the following conditions > * are met: > >
