Which ic though, just 8153B? I guess it would have worked with some variants or it wouldn't have been enabled originally?

--
 Sent from a phone, apologies for poor formatting.

On 2 April 2022 02:26:05 David Gwynne <da...@gwynne.id.au> wrote:

On 2 Apr 2022, at 03:09, Stuart Henderson <s...@spacehopper.org> wrote:

On 2022/04/01 17:13, Stuart Henderson wrote:
On 2022/04/01 10:26, Gerhard Roth wrote:
On 4/1/22 07:41, Kevin Lo wrote:

ure0: RTL8153 (0x5c10), address 00:e0:4c:xx:xx:xx
rgephy1 at ure0 phy 0: RTL8251 PHY, rev. 0

ure0: RTL8153B (0x6010), address f4:28:53:xx:xx:xx
rgephy1 at ure0 phy 0: RTL8251 PHY, rev. 0

ure0 at uhub0 port 4 configuration 1 interface 0 "Planex USB 10/100/1G/2.5G LAN" rev 2.10/30.00 addr 5
ure0: RTL8156 (0x7030), address 1c:c0:35:xx:xx:xx


You can add another one to the list that works just fine with your
patch:

ure0 at uhub1 port 1 configuration 1 interface 0 "Realtek USB 10/100/1000 LAN" rev 3.00/30.00 addr 2
ure0: RTL8153 (0x5c30), address 00:13:3b:xx:xx:xx
rgephy0 at ure0 phy 0: RTL8251 PHY, rev. 0

No new issues seen on RTL8153B:

ure0 at uhub0 port 15 configuration 1 interface 0 "Realtek USB 10/100/1000 LAN" rev 3.00/31.00 addr 10
ure0: RTL8153B (0x6010), address 00:e0:4c:38:2b:0f
rgephy0 at ure0 phy 0: RTL8251 PHY, rev. 0

I have also tested with vlan and discovered an existing issue,
it seems that vlan transmission is not working correctly: no tag
is sent on the outgoing packet. Reception appears to be ok.
This occurs with the previous code too so it is not a regression.

Tx works ok if I disable hw tagging.

that's a no brainer fix, commit it please.

Reply via email to