Re: Fix incorrect checksum generation in sr_meta_init

[Leo Unglaub]

Hey,

i cannot comment on the correctness of the change, but i have it in my 
tree running for 5 days now without any problems. This is not an OK, 
just feedback.

Greetings
Leo

On 27.03.22 01:20, Crystal Kolipe wrote:
--- softraid.c.dist     Sat Mar 26 19:40:51 2022
+++ softraid.c  Sat Mar 26 20:59:46 2022
@@ -567,8 +567,6 @@
                    sizeof(scm->scmi.scm_devname));
                memcpy(&scm->scmi.scm_uuid, &sm->ssdi.ssd_uuid,
                    sizeof(scm->scmi.scm_uuid));
-               sr_checksum(sc, scm, &scm->scm_checksum,
-                   sizeof(scm->scm_checksum));
  
  		if (min_chunk_sz == 0)
                        min_chunk_sz = scm->scmi.scm_size;
@@ -580,9 +578,12 @@
  
  	sm->ssdi.ssd_secsize = secsize;
  
-	/* Equalize chunk sizes. */
-       SLIST_FOREACH(chunk, cl, src_link)
+       /* Equalize chunk sizes and calculate chunk checksum. */
+       SLIST_FOREACH(chunk, cl, src_link) {
                chunk->src_meta.scmi.scm_coerced_size = min_chunk_sz;
+               sr_checksum(sc, scm, &scm->scm_checksum,
+                   sizeof(struct sr_meta_chunk_invariant));
+       }
  
  	sd->sd_vol.sv_chunk_minsz = min_chunk_sz;
        sd->sd_vol.sv_chunk_maxsz = max_chunk_sz;