> Date: Thu, 21 Apr 2022 11:49:45 +1000 > From: Jonathan Gray <[email protected]> > > On Wed, Apr 20, 2022 at 05:17:58PM -0500, joshua stein wrote: > > xenodm supports login_fbtab(3) to chown devices but it currently > > doesn't do anything because /etc/fbtab does not list /dev/ttyC4. It > > uses the GiveConsole and TakeConsole scripts in /etc/X11/xenodm/ to > > do this manually, but the file lists are not complete. > > > > I would like to remove all of the custom chown/chmod calls in the > > GiveConsole and TakeConsole scripts and move this into /etc/fbtab by > > adding /dev/ttyC4 and all of the wskbd* and wsmouse* devices so that > > wsconsctl from within X11 works. (These wildcards require the > > just-committed changes to libutil.) > > > > The current fbtab lists many of these devices for /dev/ttyC0 which > > seems only relevant for running OpenGL applications from the console > > (is this even possible?) or running X11 as an unprivileged user > > which we don't support anymore. > > using startx still works with the modesetting xorg driver > when the pci bus does not need to be probed > > does your diff no longer change ownership of the devices for > startx?
Right this proposal breaks startx. Maybe the installer could change /etc/fbtab when it enables xenodm? > ---------------------------- > revision 1.7 > date: 2019/09/15 12:25:40; author: kettenis; state: Exp; lines: +1 -1; > commitid: zDNBYfUsKpdfByaf; > Add ttyC4 to lost of devices to change when logging in on ttyC0 (and in > some cases also the serial console) such that X can use it as its VT > when running without root privileges. > > ok jsg@, matthieu@ > ---------------------------- > > > > > Is there any particular reason to keep these around for /dev/ttyC0? > > > > This has bit me before when I am logged into X11 as my normal user, > > I login to ttyC0 as root to check something which chowns all the > > devices to root, then later in X11 I notice no GL-using apps like > > Firefox work anymore because they can't open /dev/dri nodes. > > > > Once these file lists are ironed out, I will make diffs for all the > > other arches. > > > > > > diff --git etc/etc.amd64/fbtab etc/etc.amd64/fbtab > > index aec447931a7..df5a7a29cdd 100644 > > --- etc/etc.amd64/fbtab > > +++ etc/etc.amd64/fbtab > > @@ -1 +1,2 @@ > > -/dev/ttyC0 0600 > > /dev/console:/dev/wskbd:/dev/wskbd0:/dev/wsmouse:/dev/wsmouse0:/dev/ttyCcfg:/dev/ttyC4:/dev/dri/card0:/dev/dri/renderD128 > > +/dev/ttyC0 0600 /dev/console:/dev/wskbd*:/dev/wsmouse*:/dev/ttyCcfg > > +/dev/ttyC4 0600 > > /dev/console:/dev/wskbd*:/dev/wsmouse*:/dev/ttyCcfg:/dev/ttyC4:/dev/dri/* > > > > > >
