On 2022-04-21 21:10 +02, Alexander Bluhm <[email protected]> wrote: > On Thu, Apr 21, 2022 at 08:56:07PM +0200, Otto Moerbeek wrote: >> > Currently it allows all options. Should I make it specific to >> > router alert with IGMP or ICMP6? >> >> To me it looks like the icmp6 case already is limited to MLD? > > The question is the other way around. My current diff allows any > option with ICMP6 MLD. Do we want to restict the option to router > alert? > > In our ip6.h we have: > #define IP6OPT_JUMBO 0xC2 /* 11 0 00010 = 194 */ > #define IP6OPT_NSAP_ADDR 0xC3 /* 11 0 00011 */ > #define IP6OPT_TUNNEL_LIMIT 0x04 /* 00 0 00100 */ > #define IP6OPT_ROUTER_ALERT 0x05 /* 00 0 00101 (RFC3542, recommended) > */ > > And who knows what other options have been designed. > > In ip.h I see these: > #define IPOPT_RR 7 /* record packet route */ > #define IPOPT_TS 68 /* timestamp */ > #define IPOPT_SECURITY 130 /* provide s,c,h,tcc */ > #define IPOPT_LSRR 131 /* loose source route */ > #define IPOPT_SATID 136 /* satnet id */ > #define IPOPT_SSRR 137 /* strict source route */ > #define IPOPT_RA 148 /* router alert */ > > The option I have ever seen in the wild is router alert. So it may > be better to allow IGMP and ICMP6 multicast if router alert is the > only option in the packet.
That's my gut feeling as well. But I don't have any hard evidence that that is actually correct. However, since we learned that router-alert is an actual problem it is also a good incremental step. > > bluhm > -- I'm not entirely sure you are real.
