On Wed, Apr 27, 2022 at 12:10:59PM +0200, Claudio Jeker wrote:
> There is no need to have a rttimer queue per rdomain. The rttimer itself
> is rdomain aware and so this just make everything more complicated for no
> gain.
> 
> This diff just drops back to a single queue and initializes the queues in
> ip_init() and the IPv6 counterpart. I have no mrouter setup to test this
> but it compiles and I see no reason why it would not work.

I have tested it with regress/sys/netinet/mcast and
regress/sys/netinet6/mcast6 .  There is a minimal multicast router.

OK bluhm@ with two nits.

Could you put these declarations into header files?
Should these globals have an ip_ prefix?

>  #ifdef MROUTING
>  extern int ip_mrtproto;
> +extern struct rttimer_queue *mrouterq;
>  #endif

> +#ifdef MROUTING
> +extern struct rttimer_queue *mrouter6q;
> +#endif

Reply via email to