On 2022/05/09 23:16, Alexandr Nedvedicky wrote:
> Hello,
> 
> I'm sorry I was too fast with commit. I've just committed
> what's been suggested by bluhm@:

That's totally ok, my diff is on top and wasn't written until you
committed yours :-)

>     @@ -2186,6 +2186,7 @@ It cannot be used with
>      .Cm modulate state
>      or
>      .Cm synproxy state .
>     +With this option ICMP replies can create states.
>      .It Ar timeout seconds
>      Changes the
>      .Ar timeout
> 
> 
> > This is helpful, but because it's so surprising that "pass proto icmp"
> > doesn't pass all icmp traffic, I think it would help to mention it where
> > "proto icmp" is described too.
> > 
> > Also, the top of the text about "sloppy" just talks about the sloppy
> > TCP connection tracker, I think perhaps it would be better to lead
> > with something that suggests it has multiple functions for different
> > protocols?
> 
>     I don't object to any of your enhancements.
> 
> reads OK sashan

Thanks.

Reply via email to