On Tue, May 31, 2022 at 04:16:20PM +0200, Claudio Jeker wrote: > On Tue, May 31, 2022 at 01:16:19PM +0200, Theo Buehler wrote: > > I chose to implement the constrained versions of the RFC 3779 types from > > the draft because the OpenSSL RFC 3779 code has static IPAddrBlocks_it, > > so we have to work around that anyway. This isn't quite minimal, but it > > avoids asymmetry between ASIdentifiers and IPAddrBlocks and it's cleaner > > than reusing as many of the available RFC 3779 types as possible (which > > also means additional checks either when walking the structs or after). > > > > The diff has three parts that build on top of each other. There is no > > overlap outside of extern.h, so it should not make the review harder. > > > > The mechanical cert.c diff adjusts some sbgp_addr_*() and sbgp_as_*() to > > remove the struct parse argument so that we can use them from rsc.c. > > > > The rsc.c diff is the tricky part: it switches to templates and uses the > > cert.c functions. rsc_parse_aslist() and rsc_parse_iplist() are similar > > to sbgp_assysnum() and sbgp_ipaddrblk(), but somewhat easier. We get > > rid of the copy-paste XXXs and the last bit of low level ASN.1 fiddling. > > > > Remove the unused ASN1_frame() and cms_econtent_version() from cms.c. > > I checked the changes outside of rsc.c and am OK with those. > I also looked at the new version of rsc.c and think it is much nicer code. > I did not test the rsc.c changes with an RSC file though.
I tested with an RSC! :-) OK job@ Kind regards, Job
