On Thu, 02 Jun 2022 07:43:15 -0600, "Theo de Raadt" wrote: > Hmm, but consider these cases > > dump home > > or > > mkdir 0af > dump 0af > > or > > cd /dev && dump rsd0a
True, those would not be handled but isn't the most common usage to pass a fully-qualified path or a device name? The biggest problem I see is that this would not catch a disk uid being used but I don't think that is really fixable unless we check the string for a duid first. > Don't people always pass at least '0' (to ignore a stored level) and/or > 'a' (to avoid the volume sizing code), on very large filesystems in > particular, so it becomes good practice to always pass at least one > option, so maybe we should just state the requirement is you must pass a > flag? Or are there people passing no flags? I certainly always have, for example "dump 0f ...". That said, I don't see a downside to avoiding interpreting what is clearly a pathname as an obsolete argument. - todd
