On Sat, Jul 09, 2022 at 10:16:02PM +0300, Vitaliy Makkoveev wrote: > We set the `error' but we forgot to return it and continue to > sppp_ioctl().
This bug was introduced in rev 1.51. OK bluhm@ > Index: sys/net/if_pppoe.c > =================================================================== > RCS file: /cvs/src/sys/net/if_pppoe.c,v > retrieving revision 1.81 > diff -u -p -r1.81 if_pppoe.c > --- sys/net/if_pppoe.c 29 Jun 2022 09:08:07 -0000 1.81 > +++ sys/net/if_pppoe.c 9 Jul 2022 19:05:12 -0000 > @@ -949,6 +949,9 @@ pppoe_ioctl(struct ifnet *ifp, unsigned > > if_put(eth_if); > > + if (error != 0) > + return (error); > + > return (sppp_ioctl(ifp, cmd, data)); > } > default:
