On 2022/07/14 10:57, Claudio Jeker wrote:
> On Thu, Jul 14, 2022 at 10:51:42AM +0200, Stefan Sperling wrote:
> > On Wed, Jul 13, 2022 at 05:13:49PM +0000, Mikolaj Kucharski wrote:
> > > On Wed, Jul 13, 2022 at 05:43:59PM +0100, Stuart Henderson wrote:
> > > > > 
> > > > > Not sure how to handle long output in different way. If you don't
> > > > > specify wgdesc to the ifconfig, the diff doesn't change anything and
> > > > > ifconfig(8) output is exactly the same. If you don't find this feature
> > > > > useful, by not using it, nothing changes for you. Isn't that fair?
> > > > 
> > > > It might be better if wgpeer details would be skipped from plain
> > > > "ifconfig" and only listed if "ifconfig wg0" is used, much like
> > > > IPv4 aliases are skipped from "ifconfig" and only listed when
> > > > you use either "ifconfig -A" or "ifconfig em0" etc.
> > > > 
> > > 
> > > Ah, that helps. Thank you! Will look into it. Indeed this makes more
> > > sense. I was aware of -A, but was not aware of ifconfig <if> behaviour.
> > 
> > Perhaps also consider moving counters to netstat -s instead of ifconfig.
> 
> I don't think netstat -s is a good place for per peer stats (neither is
> ifconfig though). netstat -s shows global per protocol counters.

Agreed. These need to either be in ifconfig or some separate thing for
wg, and I much prefer ifconfig. (Everything which is listed there now
is IMHO required information, per-peer byte counters are useful to help
spot 1-way comms issues).

Reply via email to