Jonathan Gray <[email protected]> wrote:

> On Sun, Jul 24, 2022 at 08:05:26AM -0600, Theo de Raadt wrote:
> > Why not match on cpu0: .*Intel
> 
> I sent a diff a month ago with ^cpu0:*Intel(R)
> 
> semarie mentioned false positives as it could match another
> Intel device on another line on a non-Intel CPU
> 
> https://marc.info/?l=openbsd-tech&m=165579653107768&w=2

Well, then fw_update should be fixed to not perform the match over
multiple lines.

Absolutely noone expects a pattern containing '^' to match over
multiple lines.  It is only a matter of time before another pattern
acts wrong, so I think fw_update should get a proper line-matcher
so that the pattern ^cpu0: *Intel' can be used.

Reply via email to