Stuart Henderson <s...@spacehopper.org> writes:

> On 2022/07/28 12:57, Scott Cheloha wrote:
>> On Thu, Jul 28, 2022 at 07:55:40AM -0400, Dave Voutila wrote:
>> >
>> > This is breaking timecounter selection on my x13 Ryzen 5 Pro laptop
>> > running the latest kernel from snaps.
>>
>> Define "breaking".
>
> That's clear from the output:
>
> : On 2022/07/28 07:55, Dave Voutila wrote:
> : > $ sysctl -a | grep tsc
> : > kern.timecounter.choice=i8254(0) tsc(-1000) acpihpet0(1000)
> : > acpitimer0(1000)
> : > machdep.tscfreq=2096064730
> : > machdep.invarianttsc=1
> : >
> : > $ sysctl kern.timecounter
> : > kern.timecounter.tick=1
> : > kern.timecounter.timestepwarnings=0
> : > kern.timecounter.hardware=i8254
> : > kern.timecounter.choice=i8254(0) tsc(-1000) acpihpet0(1000)
> : > acpitimer0(1000)
>
>> The code detects TSC desync and marks the timecounter non-monotonic.
>
> That's good (and I think as would have happened before)
>
>> So it uses the i8254 instead.
>
> But that's not so good, there are higher prio timecounters available,
> acpihpet0 and acpitimer0, which would be better choices than i8254.

Exactly my point. Thanks Stuart.

Reply via email to