On Fri, Aug 12, 2022 at 03:16:36PM +0200, Theo Buehler wrote:
> On Fri, Aug 12, 2022 at 12:53:59PM +0200, Claudio Jeker wrote:
> > After all this slowcgi timeout fixing, here a similar thing for bgplgd(8).
> > If the timeout fires, kill the bgpctl command first with SIGTERM then with
> > SIGKILL. If the kill fails, close and cleanup the connection.
> > I also reduced the timeout to a more reasonable 30sec. Lets see how that
> > goes. This will abort full show rib commands but nobody should use those
> > anyway.
>
> Reads fine, ok
>
> > + if (kill(c->command_pid, sig) == -1) {
> > + lwarn("kill child %i after timeout", c->command_pid);
>
> party line is to prefer %d over %i (there's another one in the
> slowcgi_sig_handler()).
This is where this was copied from. Will change both.
--
:wq Claudio
