On Fri, Aug 26, 2022 at 06:25:56AM +0100, Jason McIntyre wrote:
> On Thu, Aug 25, 2022 at 09:19:09PM +0000, Klemens Nanni wrote:
> > -l takes chunks as per the manual, not specials.
> >
> > I also think that comma separated lists are marked up overly
> > confusing, so reduce it by one level, i.e. turn
> > -l chunk[,chunk[,...]]]
> > into
> > -l chunk[,...]]
> >
> > Feedback? OK?
> >
>
> hi.
>
> i think the idea of simplifying this is fine.
>
> remember, if you change the formatting in SYNOPSIS you will have to
> mirror that in the actual options list too.
Of course, thanks.
>
> personally i would not even attempt to show the optional part and just
> rely on the text description to say how multiple items can be given.
> the author obviously wanted to show that though.
I also prefer -l chunk[,...] over -l chunks or -l list or so.
OK?
Index: bioctl.8
===================================================================
RCS file: /cvs/src/sbin/bioctl/bioctl.8,v
retrieving revision 1.109
diff -u -p -r1.109 bioctl.8
--- bioctl.8 8 Feb 2021 11:20:03 -0000 1.109
+++ bioctl.8 26 Aug 2022 08:31:26 -0000
@@ -42,10 +42,10 @@
.Pp
.Nm bioctl
.Op Fl dhiPqsv
-.Op Fl C Ar flag Ns Op Pf , Ar flag Ns Op Pf , Ar ...
+.Op Fl C Ar flag Ns Op Pf , Ar ...
.Op Fl c Ar raidlevel
.Op Fl k Ar keydisk
-.Op Fl l Ar chunk Ns Op Pf , Ar chunk Ns Op Pf , Ar ...
+.Op Fl l Ar chunk Ns Op Pf , Ar ...
.Op Fl O Ar chunk | channel : Ns Ar target Ns Op Pf . Ar lun
.Op Fl p Ar passfile
.Op Fl R Ar chunk | channel : Ns Ar target Ns Op Pf . Ar lun
@@ -183,7 +183,7 @@ the options for
.Xr softraid 4
devices are as follows:
.Bl -tag -width Ds
-.It Fl C Ar flag Ns Op Pf , Ar flag Ns Op Pf , Ar ...
+.It Fl C Ar flag Ns Op Pf , Ar ...
Pass
.Ar flag
to
@@ -249,7 +249,7 @@ Detach volume specified by
Use special device
.Ar keydisk
as a key disk for a crypto volume.
-.It Fl l Ar chunk Ns Op Pf , Ar chunk Ns Op Pf , Ar ...
+.It Fl l Ar chunk Ns Op Pf , Ar ...
Use the
.Ar chunk
device list to create a new volume within the
Index: bioctl.c
===================================================================
RCS file: /cvs/src/sbin/bioctl/bioctl.c,v
retrieving revision 1.148
diff -u -p -r1.148 bioctl.c
--- bioctl.c 19 Aug 2022 17:49:10 -0000 1.148
+++ bioctl.c 25 Aug 2022 21:16:01 -0000
@@ -290,8 +290,8 @@ usage(void)
"[-u channel:target[.lun]] "
"device\n"
" %s [-dhiPqsv] "
- "[-C flag[,flag,...]] [-c raidlevel] [-k keydisk]\n"
- "\t[-l special[,special,...]] "
+ "[-C flag[,...]] [-c raidlevel] [-k keydisk]\n"
+ "\t[-l chunk[,...]] "
"[-O device | channel:target[.lun]]\n"
"\t[-p passfile] [-R chunk | channel:target[.lun]]\n"
"\t[-r rounds] "
