> On 4 Sep 2022, at 00:56, Alexander Bluhm <[email protected]> wrote: > > On Sat, Sep 03, 2022 at 11:20:17PM +0200, Hrvoje Popovski wrote: >> with this diff while booting I'm getting this witness trace > > It is not related to soreceive() diff, but TCP diff I commited > before. I forgot a mutex initalization which is fatal with witness. > Fix below. >
ok mvs@ > bluhm > > Index: netinet/tcp_subr.c > =================================================================== > RCS file: /data/mirror/openbsd/cvs/src/sys/netinet/tcp_subr.c,v > retrieving revision 1.187 > diff -u -p -r1.187 tcp_subr.c > --- netinet/tcp_subr.c 3 Sep 2022 19:22:19 -0000 1.187 > +++ netinet/tcp_subr.c 3 Sep 2022 21:54:48 -0000 > @@ -105,7 +105,7 @@ > * T tcp_timer_mtx global tcp timer data structures > */ > > -struct mutex tcp_timer_mtx; > +struct mutex tcp_timer_mtx = MUTEX_INITIALIZER(IPL_SOFTNET); > > /* patchable/settable parameters for tcp */ > int tcp_mssdflt = TCP_MSS; >
