On Fri, Sep 09, 2022 at 08:06:32PM -0400, Josiah Frentsos wrote:
> Index: strtonum.3
> ===================================================================
> RCS file: /cvs/src/lib/libc/stdlib/strtonum.3,v
> retrieving revision 1.18
> diff -u -p -r1.18 strtonum.3
> --- strtonum.3        7 Feb 2016 20:50:24 -0000       1.18
> +++ strtonum.3        10 Sep 2022 00:04:29 -0000
> @@ -35,7 +35,7 @@ The
>  function converts the string in
>  .Fa nptr
>  to a
> -.Li long long
> +.Vt long long
>  value.
>  The
>  .Fn strtonum
> @@ -56,7 +56,7 @@ or
>  sign.
>  .Pp
>  The remainder of the string is converted to a
> -.Li long long
> +.Vt long long
>  value according to base 10.
>  .Pp
>  The value obtained is then checked against the provided
> 

hi.

i fear this is either incomplete or unwanted:

$ cd /usr/src/lib/libc/stdlib
$ grep ^.Li *.3
atof.3:.Li double
atoi.3:.Li integer
atol.3:.Li long integer
atoll.3:.Li long long integer
div.3:.Li int
getopt_long.3:.Li struct option
imaxdiv.3:.Li imaxdiv_t
imaxdiv.3:.Li intmax_t
insque.3:.Li insque
insque.3:.Li remque
ldiv.3:.Li ldiv_t
ldiv.3:.Li long integer
lldiv.3:.Li lldiv_t
lldiv.3:.Li long long integer
strtod.3:.Li double
strtod.3:.Li float
strtod.3:.Li long double
strtonum.3:.Li long long
strtonum.3:.Li long long

so your fix might be correct (i'm never 100% sure on the various code
mark ups) but it doesn;t address the bigger picture. the example above
is only for libc/stdlib.

maybe ingo has an opinion on whether this needs fixed everywhere or not?

jmc

Reply via email to