On Tue, 2022-09-27 at 11:23 +0200, Florian Obser wrote: > On 2022-09-27 09:26 +02, Martijn van Duren <[email protected]> wrote: > > The caveats section talks about "user-supplied data". These string are > > constant and don't contain any '%'. Most other daemons in base use the > > setproctitle("title"); format as well. > > It's not that clear cut, snmpd(8), a daemon you might be familiar with, > uses > setproctitle("%s", p->p_title); > > while p->p_title is not user supplied ;)
True, but proc.c doesn't know how p_title is filled :-) > > The diff is probably not wrong (I only glanced at it), but I don't think > it solves a problem. It then comes down to style and I prefer things the > way they are. I only made the remark in regards to the caveat argument. If it's personal preference, that's a good enough reason for me to keep it as is. Especially for daemons that I don't work on. I addressed the argument, not the conclusion. > > > > > On Tue, 2022-09-27 at 08:07 +0100, Stuart Henderson wrote: > > > These programs seem OK as-is, they are following the advice in > > > https://man.openbsd.org/setproctitle.3#CAVEATS >
