On Wed, Oct 05, 2022 at 05:03:16PM -0400, Dave Voutila wrote:
> Matthew Martin recently presented a patch on tech@ [1] fixing some missed
> scaling from when I converted vmd(8) to use bytes instead of megabytes
> everywhere. I finally found time to wade through the code it touches and
> am proposing we simply "tedu" the incomplete feature.
>
> Does anyone use this? (And if so, how?)
>
> I don't see much value in this framework and it only adds additional
> state to track. Users can be confined by limits associated in
> login.conf(5) for the most part. There are more interesting things to
> work on, so unless anyone speaks up I'll look for an OK to remove it.
I'm not convinced that login.conf can really replace this undocumented
feature. That said, I have no opinion on whether your or Matthew's diff
is the way to go. You and mlarkin are the maintainers, so it's your call.
If your diff should go in, you probably want to garbage collect
CONFIG_USERS.
Index: usr.sbin/vmd/proc.h
===================================================================
RCS file: /cvs/src/usr.sbin/vmd/proc.h,v
retrieving revision 1.21
diff -u -p -r1.21 proc.h
--- usr.sbin/vmd/proc.h 13 Sep 2022 10:28:19 -0000 1.21
+++ usr.sbin/vmd/proc.h 6 Oct 2022 11:58:46 -0000
@@ -89,7 +89,6 @@ extern enum privsep_procid privsep_proce
#define CONFIG_RELOAD 0x00
#define CONFIG_VMS 0x01
#define CONFIG_SWITCHES 0x02
-#define CONFIG_USERS 0x04
#define CONFIG_ALL 0xff
struct privsep_pipes {
