On Mon, Oct 17, 2022 at 09:53:26PM +0200, Mark Kettenis wrote:
> > Date: Mon, 17 Oct 2022 19:45:33 +0000
> > From: Klemens Nanni <k...@openbsd.org>
> > 
> > I was looking at one particular driver and needed to know what those
> > flags are, turns out AUDIO_PROP_FULLDUPLEX is the only audio(9) property
> > that is in use.
> > 
> > The other two are only ever set in *_get_props();  their handling
> > disappeared from sys/dev/audio.c in
> > 
> >     commit 1cf2860827c8ca659d8097d8da94a5ae5b888c53
> >     Author: ratchov <ratc...@openbsd.org>
> >     Date:   Thu Jun 25 06:43:45 2015 +0000
> > 
> >         Reimplement the audio driver in a simpler way, removing 
> > unused/unusable
> >         functionality. Same API and ABI except for the removed bits and no
> >         behaviour change for programs using libsndio. With help from armani@
> >         and mpi@, thanks.
> > 
> > and the following merely moved them when they were dead code already:
> > 
> >     commit 9215aa3dfad387bca877a805534df6dcfe8722eb
> >     Author: ratchov <ratc...@openbsd.org>
> >     Date:   Wed Aug 31 07:22:43 2016 +0000
> > 
> >         Delete unused ioctls and associated macros. Move macros that are 
> > still
> >         used internally by low-level drivers from sys/audioio.h to
> >         dev/audio_if.h instead of deleting them.
> > 
> > Feedback? Objection? OK?
> 
> Is there code in ports (or even base) that relies on those flags being
> defined in sys/audioio.h.

dev/audio_if.h currently defines them.

base does not use AUDIO_PROP_*.
/usr/ports/ has no occurence of AUDIO_PROP_ and codesearch[0] only shows
the same two code snippets around AUDIO_PROP_{CAPTURE,PLAYBACK}
(which we don't have) in firefox-esr, mozjs and cubeb.

So I think this is safe.

0: https://codesearch.debian.net/search?q=AUDIO_PROP_&literal=1

Reply via email to