On Fri, Oct 21, 2022 at 12:14:16PM +0000, Klemens Nanni wrote: > On Fri, Oct 21, 2022 at 03:02:33PM +0300, Vitaliy Makkoveev wrote: > > netlock could be completely dropped here. > > We could probably drop the net lock around ifnetlist wherever the kernel > lock is currently held, but that would just make it harder to reason > about ifnetlist locking, imho. > > Eventually, the net lock (or its own lock) would be reintroduced anyway > when the kernel lock goes away, so I prefer grabbing the appropiate lock > now even when it is running with a bigger lock already. >
I missed the netlock protects `if_rdomain' here. Your initial diff diff is ok by me.
