No reason to keep kernel lock around if_clone_list() call.
> On 8 Nov 2022, at 20:27, Klemens Nanni <k...@openbsd.org> wrote:
>
> On Tue, Nov 08, 2022 at 08:04:16PM +0300, Vitaliy Makkoveev wrote:
>> The `if_cloners’ list is immutable. You don't need kernel lock
>> around if_clone_list() call.
>>
>>> case SIOCIFGCLONERS:
>>> + KERNEL_LOCK();
>>> error = if_clone_list((struct if_clonereq *)data);
>>> + KERNEL_UNLOCK();
>>> return (error);
>>
>>
>> With this fix diff looks good for me.
>
> This is going the be first unlocking diff, I just want to clearly
> separate setup churn (like this) from actual lock semantic changes.
>
