On Thu, Nov 10, 2022 at 04:13:33PM +0000, Klemens Nanni wrote: > On Fri, Nov 04, 2022 at 03:40:04PM +0100, Claudio Jeker wrote: > > So mpe(4) is a special device. It is a point-to-multipoint interface that > > does not do multicast. So setting IFF_MULTICAST on the interface is not > > correct but IPv6 depends on it because neighbor discovery. > > > > Now there is no neighbor discovery on mpe(4) the neighbors are handled via > > BGP. So lets adjust in6_ifattach() to succeed for mpe(4) interfaces and > > with that BGP IPv6 L3VPN should work. > > > > It may be an idea to move the IFF_MULTCAST check down into the > > ifp->if_type switch but right now this is good enough. I wonder if we have > > other interfaces that need similar treatment (e.g. mgre). > > Good enough for now, I also have a few minues for nd6.c but prefer > simpler changes first, then the cleanup come later.
Seeing this thread again, my OK was meant for the later "I think this is a better diff." mail, of course, just to be clear.
