On Mon, Nov 21, 2022 at 08:09:10PM +0000, ssnf wrote: > > Klemens Nanni: > > You need to be more specific, installing to a softraid volume has always > > required manual steps, so I have no idea what you did (not) do and when. > > The comment in install.sub, above my diff, states that "In case this is > a softraid device, make sure all underlying device nodes exist before > installing boot-blocks on disk." > > Without the double quotes, make_dev would not initialize my second disk > on my softraid volume, only the first disk. And once it reached the > installboot function, it would say that "/dev/rwd1c" did not exist.
I have used plain disks, single-chunk and multi-chunk softraid volumes, sofraid volumes with passphrase and with keydisks. They all worked fine. I know people use all these different scenarios. I'm not saying the code is perfect, but so far you have failed to provide anything but long sentences about comments, shell behaviour and what MIGHT have been a user error... or whatever. Deliver steps to reproduce, installation logs, machine information, version details, ANYTHING technical. > > The reason is that, without the double quotes, we get a multi-line > result from the $(bioctl|sed) command and only the first line is > actually passed to the make_dev function. > > When we place it inside the double quotes, the multi-line result > becomes a single line, and thus make_dev works as expected. I am very much aware of how the shell works, but still fail to see when/where/how this is a problem, because you are not being helpful. > > ROOTDISK in my case was sd0, the first disk was wd0 and the second one > was wd1. > > sd0 is an encrypted softraid device where wd0a is the RAID partition > and wd1 is the keydisk. > > P.S.: It was not necessarily the keydisk that was uninitialized, but > rather the second disk that resulted from the bioctl command on the > softraid volume. Keydisks used to be touched by the install program, but are now ignored. Again, you even failed to tell us which OpenBSD version you've been using, on which architecture.
