On Sun, Nov 27, 2022 at 03:21:45PM +0100, Andreas Bartelt wrote: > Hi, > > Intel Optane DC SSDs are not yet identified in CURRENT (e.g., > https://ark.intel.com/content/www/us/en/ark/products/201861/intel-optane-ssd-dc-p5800x-series-400gb-2-5in-pcie-x4-3d-xpoint.html > ). > > The following patch gets rid of the "unknown product 0x4140" output of the > corresponding nvme(4) device (tested with a Intel Optane SSD DC P5800X > Series model):
Optane DC devices don't only use the one device id. PCI\VEN_8086&DEV_0A53.DeviceDesc = "Intel(R) Solid-State Drive DC P3520 Series" PCI\VEN_8086&DEV_0A54.DeviceDesc = "Intel(R) SSD DC P4500/4600/4501/4601/4608/4510/4610/4511 Series" PCI\VEN_8086&DEV_0A55.DeviceDesc = "Intel(R) SSD DC P4600 Series" PCI\VEN_8086&DEV_2701.DeviceDesc = "Intel(R) Optane(tm) SSD DC P4800X Series" PCI\VEN_8086&DEV_4140.DeviceDesc = "Intel(R) Optane(tm) SSD DC P5800X Series" >From the previous Optane discussion: https://marc.info/?l=openbsd-tech&m=166061996818130&w=2 How about just P5800X? Index: pcidevs =================================================================== RCS file: /cvs/src/sys/dev/pci/pcidevs,v retrieving revision 1.2011 diff -u -p -r1.2011 pcidevs --- pcidevs 11 Nov 2022 07:58:42 -0000 1.2011 +++ pcidevs 2 Dec 2022 03:44:37 -0000 @@ -5418,6 +5418,7 @@ product INTEL GMA600_6 0x4106 GMA 600 product INTEL GMA600_7 0x4107 GMA 600 product INTEL GMA600_8 0x4108 GMA 600 product INTEL E600_HB 0x4114 E600 Host +product INTEL P5800X 0x4140 P5800X product INTEL PRO_WL_2200BG 0x4220 PRO/Wireless 2200BG product INTEL PRO_WL_2225BG 0x4221 PRO/Wireless 2225BG product INTEL PRO_WL_3945ABG_1 0x4222 PRO/Wireless 3945ABG > > Index: src/sys/dev/pci/pcidevs > =================================================================== > RCS file: /cvs/src/sys/dev/pci/pcidevs,v > retrieving revision 1.2011 > diff -u -p -r1.2011 pcidevs > --- src/sys/dev/pci/pcidevs 11 Nov 2022 07:58:42 -0000 1.2011 > +++ src/sys/dev/pci/pcidevs 27 Nov 2022 13:51:00 -0000 > @@ -5418,6 +5418,7 @@ product INTEL GMA600_6 0x4106 GMA 600 > product INTEL GMA600_7 0x4107 GMA 600 > product INTEL GMA600_8 0x4108 GMA 600 > product INTEL E600_HB 0x4114 E600 Host > +product INTEL OPTANE_DC 0x4140 Optane DC > product INTEL PRO_WL_2200BG 0x4220 PRO/Wireless 2200BG > product INTEL PRO_WL_2225BG 0x4221 PRO/Wireless 2225BG > product INTEL PRO_WL_3945ABG_1 0x4222 PRO/Wireless 3945ABG > > Index: src/sys/dev/pci/pcidevs.h > =================================================================== > RCS file: /cvs/src/sys/dev/pci/pcidevs.h,v > retrieving revision 1.2005 > diff -u -p -r1.2005 pcidevs.h > --- src/sys/dev/pci/pcidevs.h 11 Nov 2022 07:59:19 -0000 1.2005 > +++ src/sys/dev/pci/pcidevs.h 27 Nov 2022 13:51:24 -0000 > @@ -5423,6 +5423,7 @@ > #define PCI_PRODUCT_INTEL_GMA600_7 0x4107 /* GMA 600 */ > #define PCI_PRODUCT_INTEL_GMA600_8 0x4108 /* GMA 600 */ > #define PCI_PRODUCT_INTEL_E600_HB 0x4114 /* E600 Host */ > +#define PCI_PRODUCT_INTEL_OPTANE_DC 0x4140 /* Optane DC */ > #define PCI_PRODUCT_INTEL_PRO_WL_2200BG 0x4220 /* PRO/Wireless > 2200BG */ > #define PCI_PRODUCT_INTEL_PRO_WL_2225BG 0x4221 /* PRO/Wireless > 2225BG */ > #define PCI_PRODUCT_INTEL_PRO_WL_3945ABG_1 0x4222 /* > PRO/Wireless 3945ABG > */ > > Index: src/sys/dev/pci/pcidevs_data.h > =================================================================== > RCS file: /cvs/src/sys/dev/pci/pcidevs_data.h,v > retrieving revision 1.2000 > diff -u -p -r1.2000 pcidevs_data.h > --- src/sys/dev/pci/pcidevs_data.h 11 Nov 2022 07:59:20 -0000 1.2000 > +++ src/sys/dev/pci/pcidevs_data.h 27 Nov 2022 13:51:45 -0000 > @@ -19068,6 +19068,10 @@ static const struct pci_known_product pc > "E600 Host", > }, > { > + PCI_VENDOR_INTEL, PCI_PRODUCT_INTEL_OPTANE_DC, > + "Optane DC", > + }, > + { > PCI_VENDOR_INTEL, PCI_PRODUCT_INTEL_PRO_WL_2200BG, > "PRO/Wireless 2200BG", > }, > > Best regards > Andreas > >
